wealthfront/magellan

Actionbar design discussions

Closed this issue · 1 comments

bangarharshit commented

Thanks for the library. It's super easy to use and I am working on my fork.

A not so great part of the library is the actionbar setup. Hiding actionbar and click listener delegation is not a very clean idea. One point of improvement is to ignore setSupportActionBar(toolbar) in favor of toolbar inflate menu and click listeners https://stackoverflow.com/questions/26511981/toolbar-inflatemenu-seems-to-do-nothing.

You can have completely custom toolbars and they can be treated as just any other view. The library doesn't need to handle any menu related functionality.

Will be happy to send a PR.

bangarharshit commented

Actually, it is possible to do this in the current form. Will be happy to add an example to showcase. It will be much neater than the current form.