wealthfront/magellan

Consider making screen.showDialog() accessible from the view

Closed this issue · 1 comments

It sometimes makes sense to describe the layout of a dialog in the view rather than the screen, so I think it makes sense to expose a showDialog() method on the view (that uses screen.showDialog() under the hood)

After thinking more about this and using the pattern in a project, I don't think it's a useful pattern or one that we should encourage. Showing a dialog is a dramatic UI change that should be handled at the screen level