weaveworks/mesh

make gossipInterval configurable

murali-reddy opened this issue · 1 comments

Right now gossipInterval is hard-coded to be 30 sec in mesh library. So every 30 sec there is topology update that is gossiped. Processing topology update received through gossip can get expensive when the number of nodes participating in the gossip increases.

Is there a reason to gossip periodically? Does sending the topology updated when there is topology change detected should be sufficient? If periodic gossip is required then is it desirable to increase the gossip interval to higher value.

cpu.pdf

Please find the attached CPU profile. 1/3 of time was send in processing topology gossip updates received from other peers. There is a topology update sent instantly when there is connections add/delete are detected by local peer. So its desirable to keep the interval less aggressive at least for topology gossip channel.