Angular 5+ support
Opened this issue · 10 comments
After install, it warns about @angular/core@^4.0.0 dependency.
ngx-image-gallery@1.3.1 requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself.
I will updated in the next few days!
Worth updating straight to angular 6 and rxjs 6.
+1 angular 6 support
Any updates on this? I would really love to get rid of those warnings...
Angular 7 has just come out, this would be a good time to update this package...
Anyone else trying to run in Angular 7 and seeing compilation issues in AOT? I submitted a PR (#41), but I haven't been able to verify the fix as I have yet to build this from source but I'd be shocked if others weren't going to run into this problem also.
Environment
- Angular 7.1.4
- TypeScript 3.1.6
- Node 10.x LTS
I'm using skipLibCheck in my tsconfig file so I'm able to use angular 7 with aot.
@HarelM thanks for the idea. That exact suggestion didn't work for me. Instead, the fix for me was
"angularCompilerOptions": { "fullTemplateTypeCheck": false }
It might matter that this code was in an Angular library for me; not sure though...
@maintainers any updates on this? I'm still getting warnings when using npm install...
@thatisuday I saw your last commit about looking for someone to help maintain this package.
I'll be happy to help out, please let me know how I can help.
I would love to start with this issue which is open for more than a year now.