web-push-libs/web-push-csharp

Remove Newtonsoft.Json dependency

7702244 opened this issue · 4 comments

7702244 commented

You are only using json serialization in the JwsSigner.cs class. Why not get rid of the heavy dependency Newtonsoft.Json and use the standard fast and simple JsonSerializer (Documentation)

7702244 commented

The project is abandoned?
Please, review the pull request #95

au5ton commented

JsonSerializer seems to only available in .NET Core 3.0 and later. This project seems to be targeting .NET versions before that, so Newtonsoft is necessary.

https://learn.microsoft.com/en-us/dotnet/api/system.text.json.jsonserializer?view=net-8.0#applies-to

7702244 commented

Maybe it would be better to make a separate version for the new .NET without unnecessary dependencies?

  • 👎1
coryjthompson commented

Thanks @7702244.

This has been merged and will be in the next release.

  • 👍1