web-scrobbler/metadata-filter

Exclamation marks cut off

CTimmerman opened this issue · 0 comments

Describe the bug
Some tracks contain one or more exclamation marks at the end, which are currently being cut off.

How to reproduce
Steps to reproduce the behavior:

  1. Go to https://www.youtube.com/watch?v=AE4b9jO1uB4
  2. Click on play
  3. See "Go" scrobbled instead of "Go!!!"

Expected behavior
Scrobble "Go!!!"

Debug logs

Tab 1134: New song detected: {
  "track": "Go",
  "artist": "FLOW",
  "album": null,
  "albumArtist": null,
  "uniqueID": "AE4b9jO1uB4",
  "duration": 265,
  "currentTime": 2,
  "isPlaying": true,
  "trackArt": null,
  "isPodcast": false
}
scrobble-service.js:91 Send "get info" request: 1
util.js:40 Last.fm: track.getinfo response:
{
  "track": {
    "name": "GO!!!",
    "mbid": "72e34904-fbad-49f1-9b20-e3e68c52df94",
    "url": "https://www.last.fm/music/Flow/_/GO%21%21%21",
    "duration": "238000",
    "streamable": {
      "#text": "0",
      "fulltrack": "0"
    },
    "listeners": "59913",
    "playcount": "538717",
    "artist": {
      "name": "Flow",
      "mbid": "ec2af38e-6f24-4073-9504-dbfa8e823df5",
      "url": "https://www.last.fm/music/Flow"
    },
    "album": {
      "artist": "Flow",
      "title": "GO!!!",
      "mbid": "dd0a44c3-0a00-48b5-b483-f5bebf424247",
      "url": "https://www.last.fm/music/Flow/GO%21%21%21",
      "image": [
        {
          "#text": "https://lastfm.freetls.fastly.net/i/u/34s/4dac53926da4b5a3a7f70c69f20eb124.png",
          "size": "small"
        },
        {
          "#text": "https://lastfm.freetls.fastly.net/i/u/64s/4dac53926da4b5a3a7f70c69f20eb124.png",
          "size": "medium"
        },
        {
          "#text": "https://lastfm.freetls.fastly.net/i/u/174s/4dac53926da4b5a3a7f70c69f20eb124.png",
          "size": "large"
        },
        {
          "#text": "https://lastfm.freetls.fastly.net/i/u/300x300/4dac53926da4b5a3a7f70c69f20eb124.png",
          "size": "extralarge"
        }
      ],
      "@attr": {
        "position": "1"
      }
    },
    "userplaycount": "6",
    "userloved": "1",
    "toptags": {
      "tag": [
        {
          "name": "anime",
          "url": "https://www.last.fm/tag/anime"
        },
        {
          "name": "Naruto",
          "url": "https://www.last.fm/tag/Naruto"
        },
        {
          "name": "J-rock",
          "url": "https://www.last.fm/tag/J-rock"
        },
        {
          "name": "japanese",
          "url": "https://www.last.fm/tag/japanese"
        },
        {
          "name": "Soundtrack",
          "url": "https://www.last.fm/tag/Soundtrack"
        }
      ]
    },
    "wiki": {
      "published": "22 Apr 2018, 05:23",
      "summary": "TV anime: Naruto OP04 song. Read more on Last.fm.",
      "content": "TV anime: Naruto OP04 song. Read more on Last.fm. User-contributed text is available under the Creative Commons By-SA License; additional terms may apply."
    }
  }
}
coverartarchive.js:13 Found album artwork via LastFM
util.js:40 Tab 1134: Song finished processing: {
  "parsed": {
    "track": "Go",
    "artist": "FLOW",
    "album": null,
    "albumArtist": null,
    "uniqueID": "AE4b9jO1uB4",
    "duration": 265,
    "currentTime": 2,
    "isPlaying": true,
    "trackArt": null,
    "isPodcast": false
  },
  "processed": {
    "track": "Go!!!",
    "album": "America",
    "artist": "Flow",
    "albumArtist": null,
    "duration": null
  },
  "flags": {
    "isScrobbled": false,
    "isCorrectedByUser": true,
    "isValid": true,
    "isMarkedAsPlaying": false,
    "isSkipped": false,
    "isReplaying": false
  },
  "metadata": {
    "userloved": true,
    "startTimestamp": 1589383703,
    "label": "YouTube",
    "trackArtUrl": "https://lastfm.freetls.fastly.net/i/u/300x300/4dac53926da4b5a3a7f70c69f20eb124.png",
    "artistUrl": "https://www.last.fm/music/Flow",
    "trackUrl": "https://www.last.fm/music/Flow/_/GO%21%21%21",
    "albumUrl": "https://www.last.fm/music/Flow/GO%21%21%21",
    "userPlayCount": 6,
    "albumMbId": "dd0a44c3-0a00-48b5-b483-f5bebf424247"
  },
  "internalId": "AE4b9jO1uB4",
  "connectorLabel": "YouTube"
}
util.js:40 Tab 1134: The song will be scrobbled in 133 seconds
util.js:40 Tab 1134: The song will be repeated in 265 seconds
scrobble-service.js:107 Send "now playing" request: 1
util.js:40 Last.fm: track.updatenowplaying response:
{
  "nowplaying": {
    "artist": {
      "corrected": "0",
      "#text": "Flow"
    },
    "ignoredMessage": {
      "code": "0",
      "#text": ""
    },
    "album": {
      "corrected": "0",
      "#text": "America"
    },
    "albumArtist": {
      "corrected": "0",
      "#text": ""
    },
    "track": {
      "corrected": "0",
      "#text": "Go!!!"
    }
  }
}
util.js:40 Tab 1134: Song set as now playing

Good thing it remembers me correcting it last time.

Environment (please complete the following information)

  • OS: Windows 10
  • Browser: Chrome 81.0.4044.138 (Official Build) (64-bit)
  • Extension version: 2.31.0