webinstall/webi-installers

Simple refactor: find-and-replace `whoami` with `id -u -n` in scripts

Opened this issue · 2 comments

coolaj86 commented

whoami is generally available on all Unix-y systems, but id -u -n is the POSIX standard with guaranteed behavior.

This is literally as simple as doing a find-and-replace across the repo (such as with sd, or any code editor tool).

Finding the files with whoami:

git clone https://github.com/webinstall/webi-installers ./webi-installers
pushd webi-installers/
rg 'whoami' || grep -r 'whoami' .

For reference: https://pubs.opengroup.org/onlinepubs/009695399/utilities/id.html

shuchitpant commented

Hi @coolaj86,

I would like to work on this issue.

Could you please assign this issue to me?

shuchitpant commented

Hi AJ,

I've raised a PR (#915 ), that addresses this issue, kindly go through this and let me know if there are any changes.