webiny/webiny-js

inconsistent pb element save-behavior in editor

woeps opened this issue · 0 comments

woeps commented

Version

5.37.2

Operating System

Linux

Browser

Firefox 116.0.2 (64-bit)

What are the steps to reproduce this bug?

Drop one of the following pb elements onto a page in the editor (without any further modification of the element's settings):

  • basic
    • icon
    • image gallery
  • layout
    • grid
    • carousel
    • tabs
    • accordion
  • form
    • form
  • embeds
    • soundcloud
    • vimeo
    • youtube
    • iframe
  • social
    • pinterest
    • twitter
  • code
    • codesandbox

Preview the page (no matter if published or not).

What is the expected behavior?

To see the newly dropped element or at least a placeholder noting "this element is not yet fully configured" (or similar).

What do you see instead?

The newly dropped element is not visible at all.

Additional information

The elements are are not saved (updatePage mutation won't get called) upon dropping the listed elements.

The following elements trigger the updatePage mutation immediately upon dropping it onto a page:

  • basic
    • heading
    • paragraph
    • button
    • list of pages

This inconsistent behavior lead to quite some confusion in my team currently evaluation webiny. I believe the behavior should be consistent.

This concern was first raised on Slack.

Possible solution

Trigger the updatePage for any element being dropped onto the page (in the pb editor) and have elements, which need some settings to correctly render, a "fallback" to render a warning about not being fully configured.