webkom/lego-editor

Editor broken on Android

Closed this issue · 4 comments

😢

21-02-02-16-09-24.mp4

This is not an issue with the editor itself, but rather the implementation used with redux-form. There is an issue for lego-webapp: webkom/lego#1383

I'm not really sure if we can do anything about this here, or if it has to be fixed in lego-webapp (which is what I'm guessing), so I'll leave it open for now.

The example is buggy too tho.

21-02-03-11-01-31.mp4

Also, doesnt redux-form work similar on mobile as on desktop, or haven't we examined what is causing the issue?

The example is buggy too tho.

Hmm, it seems you are indeed correct. It's not as noticeable it seems, but still an issue 🤔. That's probably why I haven't noticed it.

Also, doesnt redux-form work similar on mobile as on desktop, or haven't we examined what is causing the issue?

I don't remember quite, but when I tested this issue some time ago, I believe removing redux-form handlers improved the situation quite a lot. I'll have to look into this some more, but it seems like this happens whenever you add event handlers, so there is probably some event leaking on mobile causing issues. (The example app has an onChange handler that just console.logs). So the reason this only happens on mobile is probably due to the differences in how mobile/desktop handle input events.

I'm now pretty sure we cannot fix this, and that it has to be implemented by slate.js. There seems to be very active development on android support though (ianstormtaylor/slate#3786), so hopefully we can get the fix soon. (We would have to upgrade slate though 😫