webrtc-rs/sctp

CT_CWR Wrongly Set to ECNE as a Return String

eshikafe opened this issue · 1 comments

eshikafe commented

I have some observations while reviewing the chunk_type.rs file and the SCTP RFC 4960 document

sctp/src/chunk/chunk_type.rs

Line 21 in 24aca40

pub(crate) const CT_CWR: ChunkType = ChunkType(13);

sctp/src/chunk/chunk_type.rs

Line 42 in 24aca40

CT_CWR => "ECNE", // Explicit Congestion Notification Echo

According to RFC 4960 section 3.2,
12 - Reserved for Explicit Congestion Notification Echo (ECNE)
13 - Reserved for Congestion Window Reduced (CWR)

Line 42 should be: CT_CWR => "CWR",.

So there should be separate entries for ECNE (i.e ID Value 12)

pub(crate) const CT_ECNE: ChunkType = ChunkType(12);
CT_ECNE => "ECNE",
k0nserv commented

We have migrated this crate to the monorepo(webrtc-rs/webrtc) please re-open this issue over there.