Incorrect encoding of Buffer

Question

Incorrect encoding of Buffer

ngorchilov opened this issue 12 years ago · 4 comments

This code produces invald result on encoding binary data (like info/pieces section of torrent file) as default type casting to string is assuming utf-8 encoding
if( data instanceof Buffer )
return data.length + ':' + data
The correct way is to specify 'binary' encoding explicitly. I.e.
if( data instanceof Buffer )
return data.length + ':' + data.toString('binary')

Answer 1 · 2012-12-17T12:08:24.000Z

Yup, you're wright, but the binary encoding method is deprecated and shouldn't be used, as stated in the docs:

This encoding method is deprecated and should be avoided in favor of Buffer objects where possible.
This encoding will be removed in future versions of Node.

I'll have a look at this and add a test case for a real life torrent file.

Answer 2 · 2012-12-18T07:08:43.000Z

Then, the only option IMHO is bencode to produce a Buffer instead of string.

Answer 3 · 2012-12-18T13:00:14.000Z

I think producing a Buffer when encoding is absolutely okay. It feels more correct than a string.
But do we need to worry about breaking the API?

Answer 4 · 2012-12-18T14:09:59.000Z

I guess we can close this now, has been fixed in b746034 - sent via Hojoki