wei/socialify

"Issues" badge should only include "open" issues

impressivewebs opened this issue · 5 comments

impressivewebs commented

Great tool!

Currently, when selecting the "issues" checkbox, it includes all issues, including ones that have been closed. It seems it would be much better to include only the "open" issues. Does the GitHub API allow that instead of all issues?

CryogenicPlanet commented

@impressivewebs Yes the Github API does support and we can achieve this by changing the graphql.

I would like to leave this open for discussion for the community and @wei to see which would be a better fit for projects, but it should be a pretty trivial change to make.

Note to self:
Change the following lines too and regenerate relay

socialify/common/relay/repoQuery.ts

Lines 11 to 13 in f65e9c5

issues {
totalCount
} 

 issues(states: OPEN) {
      totalCount
    }
  • 👍1
impressivewebs commented

Yeah, I definitely think it would be better with only open issues. As an example, if you were including a big project like React it would list almost 10,000 "issues", which isn't accurate at all, since the actual "open" issues are only about 480.

Just my two cents. Thanks for the quick response!

  • ❤️1
wei commented

I agree, I say we do the same for the PRs too.

impressivewebs commented

@CryogenicPlanet I just tested it, works great! This is much better.

  • 🎉2
wei commented

Thanks for the suggestion! Enjoy!