welaika/photocopier

sshpass is not working

Arkham opened this issue · 2 comments

As found here, welaika/wordmove#25

There is something wrong in this piece of code:

https://github.com/stefanoverna/photocopier/blob/master/lib/photocopier/ssh.rb#L72

Aside from mixing gateway and non-gateway options, we shouldn't rely on options[:sshpass], because if a user doesn't supply a sshpass field, this method will default to nil, thus disabling sshpass.

@Arkham do you have time to propose a patch?

This should be fixed.