werf/nelm

werf dismiss --with-namespace hangs when there is a PVC in this namespace

distorhead opened this issue · 2 comments

werf dismiss --with-namespace hangs when there is a PVC in this namespace

Update. This is probably not related to PVC.

Potential race-condition is here: https://github.com/werf/kubedog/blob/main/pkg/trackers/elimination/elimination.go#L136

  • Check object exists using objects list.
  • Then run informer.

If object was found in objects list, then deleted, then we run informer, then this informer may not receive object "deleted" signal which would result in hanging elimination process.

In werf v2 we have very different logic for tracking resource deletions, so there is probably no such issue. But werf dismiss is still using the old deployment/tracking engine. When we migrate werf dismiss to Nelm (#6155) it surely should be solved.