wesselt/bunq2ynab

Execution error with the `callback-marker` configuration variable

etorreborre opened this issue · 2 comments

The add_callbacks function is raising an exception on line 18, saying that callback-marker should be callback_marker instead. Then the default value for that config variable had to be changed to bunq2ynab-lambda:

def add_callbacks(sync):
    url = state.get("aws_callback")
    log.info("SSM callback = \"{}/\"".format(url))
    if not url:
        return
    log.info("Adding callbacks...")
    for uid in sync.get_bunq_user_ids():
        callback_marker = config.get("callback_marker") or "bunq2ynab-lambda"
        bunq_api.add_callback(uid, callback_marker, url)

Thanks for reporting, you're right about the underscore. It looks fixed in the latest version: https://github.com/wesselt/bunq2ynab/blob/master/lambda_function.py Not sure if it's updated on the AWS repository.

I think there's still an inconsistency on https://github.com/wesselt/bunq2ynab/blob/master/lambda_function.py#L18 where bunq2ynab-autosync should be bunq2ynab-lambda instead to match the AWS Lambda setup.

It worked fine after manually making this change in my deployment.