westdabestdb/bubble_bottom_bar

hasInk can fill up icon and not disappear any more

Closed this issue · 1 comments

nohli commented

If (hasInk) on an iPhone without physical home button (>= iPhone X) and you press and hold an icon of the bubble bottom bar (which is then animated through the hasInk feature) while simultaneously (with the same finger) touching the home indicator and swiping up, the ink fills up the icon and doesn't go away any more until you close and reopen the app.

nohli commented

Actually, yesterday I looked into flutter tests and found out that this package was causing an error:

══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
The intrinsic dimension methods of the RenderPadding class returned values that violate the
intrinsic protocol contract.
The following failures was detected:
getMinIntrinsicWidth(Infinity) returned a larger value (295.6) than
getMaxIntrinsicWidth(Infinity) (223.6)
getMinIntrinsicWidth(600.0) returned a larger value (295.6) than getMaxIntrinsicWidth(600.0)
(223.6)
If you are not writing your own RenderBox subclass, then this is not
your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=BUG.md

...so I tested a bunch of stuff and found out that removing the line

fabLocation: BubbleBottomBarFabLocation.end,

would fix it.

This way a bit of the beautiful design, integrating the button into the bar, is gone, but

  • now it doesn't show an error during testing AND

  • the behavior regarding the ink is also gone