wet-boew/wet-boew-php

Missing the IE conditional comments

Closed this issue · 7 comments

crochefort commented

As per Nick comment in this issue!

wet-boew/wet-boew#4331

Will need to edit line 27 and 28 in this file:
dist-php/inc/head-doc.php

from

<!--[if lt IE 9]><html class="no-js lt-ie9" lang="en"><![endif]-->
<!--[if gt IE 8]><!-->

to

<!--[if IE 7]><html lang="fr" class="no-js ie7"><![endif]-->
<!--[if IE 8]><html lang="fr" class="no-js ie8"><![endif]-->
<!--[if gt IE 8]><!-->
nschonni commented

FWI, the IE7 version is for the 3.x version, the current version is correct for v4 https://github.com/wet-boew/wet-boew/blob/v4.0/site/layouts/default.hbs#L1-L4

crochefort commented

So if it's correct it's actually a bug. I have the same thing in my IE8 html code at the top!

What do you want to do @nschonni ??
Reopen the other one and take a look?

crochefort commented

Look the same issue here : wet-boew/wet-boew#1999

nschonni commented

OK, we'll need a reproducible HTML example then

crochefort commented

Not sure if Patrick can test on is side... It's more complex on my side...

upsonp commented

I don't have access to IE8 or lower, I had some testing site I was using for a bit, maybe ?sause labs?.

I'm really swamped at the moment though, I don't expect I'll have time until at least Sunday.

crochefort commented

I just figure out the error ...

Patrick you need to fix the line 27 in dist-php/inc/head-doc.php

<!--[if lt IE 9]><html class="no-js lt-ie9" lang="en"><![endif]-->

The lang is not coded

As soon you resolve this you can close the issue!