wfithian/sequential-selection

missing functions for max-t and max-z tests

Opened this issue · 0 comments

I have looked in your code for a function applying the max-t or max-z test to a lasso (preferably), lar, forward stagewise or forward stepwise model fit.
I did not find a suitable function there.

forwardStepMaxtInf() from exact.R
This seems to be the right function
However it takes as input fsfit presumably a forward stepwise fit object
It references fsfit$pred
$pred is not part of the selectiveInference:: fs() return object
In RobsCodeTab1.R the forward stepwise model fit is generated via forwardStep() not fs(), but forwardStep() is not part of the released selectiveInference library

PS:
exactLassoStepInf () from exact.R
This must be broken. It doesn't use its input variable larfit, possibly miscalls it lar.

regards
Desmond