whalebrew/whalebrew

Build scripts failing: script/build and script/run

sushlala opened this issue · 1 comments

I get this error when I try to build the source, or build the docker image:

../client/client.go:16: cli.UpdateClientVersion undefined (type *client.Client has no field or method UpdateClientVersion)
whalebrew $git reset --hard HEAD
HEAD is now at cf6c366 Fix titles in readme
whalebrew $
whalebrew $
whalebrew $
whalebrew $./script/build 
Number of parallel builds: 3

-->    darwin/amd64: github.com/bfirsh/whalebrew
-->     linux/amd64: github.com/bfirsh/whalebrew

2 errors occurred:
--> darwin/amd64 error: exit status 2
Stderr: # github.com/bfirsh/whalebrew/client
../client/client.go:16: cli.UpdateClientVersion undefined (type *client.Client has no field or method UpdateClientVersion)

--> linux/amd64 error: exit status 2
Stderr: # github.com/bfirsh/whalebrew/client
../client/client.go:16: cli.UpdateClientVersion undefined (type *client.Client has no field or method UpdateClientVersion)

Build image:

whalebrew $./script/run 
Sending build context to Docker daemon  274.9kB
Step 1/7 : FROM golang:1.7
 ---> 225948c9a8b1
Step 2/7 : RUN mkdir -p /go/src/github.com/bfirsh/whalebrew
 ---> Using cache
 ---> e177700e163b
Step 3/7 : WORKDIR /go/src/github.com/bfirsh/whalebrew
 ---> Using cache
 ---> b7b41bfeafa5
Step 4/7 : COPY . /go/src/github.com/bfirsh/whalebrew
 ---> b35091b04657
Removing intermediate container ba333628eedc
Step 5/7 : RUN go-wrapper download -t ./...
 ---> Running in 7577b4895939
+ exec go get -v -d -t ./...
github.com/Songmu/prompter (download)
github.com/mattn/go-isatty (download)
Fetching https://golang.org/x/crypto/ssh/terminal?go-get=1
Parsing meta tags from https://golang.org/x/crypto/ssh/terminal?go-get=1 (status code 200)
get "golang.org/x/crypto/ssh/terminal": found meta tag main.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto/ssh/terminal?go-get=1
get "golang.org/x/crypto/ssh/terminal": verifying non-authoritative meta tag
Fetching https://golang.org/x/crypto?go-get=1
Parsing meta tags from https://golang.org/x/crypto?go-get=1 (status code 200)
golang.org/x/crypto (download)
Fetching https://golang.org/x/sys/unix?go-get=1
Parsing meta tags from https://golang.org/x/sys/unix?go-get=1 (status code 200)
get "golang.org/x/sys/unix": found meta tag main.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at https://golang.org/x/sys/unix?go-get=1
get "golang.org/x/sys/unix": verifying non-authoritative meta tag
Fetching https://golang.org/x/sys?go-get=1
Parsing meta tags from https://golang.org/x/sys?go-get=1 (status code 200)
golang.org/x/sys (download)
github.com/docker/docker (download)
Fetching https://gopkg.in/yaml.v2?go-get=1
Parsing meta tags from https://gopkg.in/yaml.v2?go-get=1 (status code 200)
get "gopkg.in/yaml.v2": found meta tag main.metaImport{Prefix:"gopkg.in/yaml.v2", VCS:"git", RepoRoot:"https://gopkg.in/yaml.v2"} at https://gopkg.in/yaml.v2?go-get=1
gopkg.in/yaml.v2 (download)
github.com/spf13/cobra (download)
github.com/spf13/pflag (download)
github.com/spf13/viper (download)
github.com/fsnotify/fsnotify (download)
github.com/hashicorp/hcl (download)
github.com/magiconair/properties (download)
github.com/mitchellh/mapstructure (download)
github.com/pelletier/go-toml (download)
github.com/spf13/afero (download)
Fetching https://golang.org/x/text/transform?go-get=1
Parsing meta tags from https://golang.org/x/text/transform?go-get=1 (status code 200)
get "golang.org/x/text/transform": found meta tag main.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/transform?go-get=1
get "golang.org/x/text/transform": verifying non-authoritative meta tag
Fetching https://golang.org/x/text?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
golang.org/x/text (download)
Fetching https://golang.org/x/text/unicode/norm?go-get=1
Parsing meta tags from https://golang.org/x/text/unicode/norm?go-get=1 (status code 200)
get "golang.org/x/text/unicode/norm": found meta tag main.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text/unicode/norm?go-get=1
get "golang.org/x/text/unicode/norm": verifying non-authoritative meta tag
github.com/spf13/cast (download)
github.com/spf13/jwalterweatherman (download)
github.com/stretchr/testify (download)
 ---> 9fecb8e44b62
Removing intermediate container 7577b4895939
Step 6/7 : RUN go-wrapper install
 ---> Running in dd92b5641aa4
+ exec go install -v
github.com/mattn/go-isatty
golang.org/x/sys/unix
github.com/docker/docker/vendor/github.com/opencontainers/go-digest
github.com/docker/docker/vendor/github.com/docker/distribution/digestset
github.com/docker/docker/vendor/github.com/docker/distribution/reference
github.com/docker/docker/api
github.com/docker/docker/api/types/blkiodev
github.com/docker/docker/api/types/mount
github.com/docker/docker/api/types/strslice
github.com/docker/docker/vendor/github.com/docker/go-connections/nat
github.com/docker/docker/vendor/github.com/docker/go-units
github.com/docker/docker/api/types/container
golang.org/x/crypto/ssh/terminal
github.com/docker/docker/api/types/versions
github.com/docker/docker/api/types/filters
github.com/Songmu/prompter
github.com/docker/docker/api/types/network
github.com/docker/docker/vendor/github.com/opencontainers/image-spec/specs-go
github.com/docker/docker/vendor/github.com/gogo/protobuf/proto
github.com/docker/docker/vendor/github.com/opencontainers/image-spec/specs-go/v1
github.com/docker/docker/api/types/registry
github.com/docker/docker/api/types/events
github.com/docker/docker/api/types/image
github.com/docker/docker/api/types/time
github.com/docker/docker/vendor/golang.org/x/net/proxy
github.com/docker/docker/vendor/github.com/docker/go-connections/sockets
github.com/docker/docker/vendor/github.com/pkg/errors
github.com/docker/docker/vendor/github.com/docker/go-connections/tlsconfig
github.com/docker/docker/vendor/golang.org/x/net/context
github.com/docker/docker/vendor/golang.org/x/net/context/ctxhttp
gopkg.in/yaml.v2
github.com/docker/docker/api/types/swarm/runtime
github.com/docker/docker/api/types/swarm
github.com/docker/docker/api/types
github.com/bfirsh/whalebrew/version
github.com/spf13/pflag
github.com/docker/docker/api/types/volume
github.com/docker/docker/client
github.com/spf13/cobra
github.com/fsnotify/fsnotify
github.com/hashicorp/hcl/hcl/strconv
github.com/hashicorp/hcl/hcl/token
github.com/bfirsh/whalebrew/client
github.com/bfirsh/whalebrew/packages
# github.com/bfirsh/whalebrew/client
client/client.go:16: cli.UpdateClientVersion undefined (type *client.Client has no field or method UpdateClientVersion)
github.com/hashicorp/hcl/hcl/ast
github.com/hashicorp/hcl/hcl/scanner
github.com/hashicorp/hcl/json/token
github.com/hashicorp/hcl/hcl/parser
github.com/hashicorp/hcl/json/scanner
github.com/hashicorp/hcl/json/parser
github.com/magiconair/properties
github.com/hashicorp/hcl
github.com/mitchellh/mapstructure
github.com/pelletier/go-toml
github.com/spf13/afero/mem
golang.org/x/text/transform
golang.org/x/text/unicode/norm
github.com/spf13/cast
github.com/spf13/jwalterweatherman
github.com/spf13/afero
github.com/spf13/viper
The command '/bin/sh -c go-wrapper install' returned a non-zero code: 2

I'm running

whalebrew $sw_vers 
ProductName:	Mac OS X
ProductVersion:	10.12.6
BuildVersion:	16G29

If I comment out line 16, the build succeeds. Thoughts?

This passes the build:

whalebrew $git diff
diff --git a/client/client.go b/client/client.go
index 2b683dc..5bb6317 100644
--- a/client/client.go
+++ b/client/client.go
@@ -13,6 +13,6 @@ func NewClient() (*client.Client, error) {
        if err != nil {
                return cli, err
        }
-       cli.UpdateClientVersion(DefaultVersion)
+  //cli.UpdateClientVersion(DefaultVersion)
        return cli, nil
 }

Hi,
Thanks for reporting.

I think this issue is related to the commit moby/moby@5f1d94e

This issue should be solved by 9116886
script/build is invoked by travis and has succeeded in the master commit.

I am hence closing this issue. Please feel free to re-open it if you still have this issue