The open() method's "async" argument is now invalid per IDL
tabatkins opened this issue · 7 comments
Since the async iterator<> feature was added to WebIDL, async now tokenizes as a keyword, not an ident, and thus is invalid as an argument name. You need to prefix it with a _, like _async.
Will whatwg/webidl#769 fix this @saschanaz?
Assuming the edits in that PR are valid, yes it does.
It does not solve this because it only covers operations and attributes. I can modify the PR to cover this.
Do we still need a Bikeshed or widlparser update? #252 is failing to build at the moment because of this (I think).
The Bikeshed change that introduced this was speced/bikeshed@450e049, and the Travis build for it did fail: https://travis-ci.org/tabatkins/bikeshed/builds/569899644
Changes around the open() method show up in the diff.
I think Bikeshed needs an update, so I've filed speced/bikeshed#1507 for that, and speced/bikeshed#1506 for process which allowed for the regression.
I've sent speced/bikeshed#1509 and confirmed that fixes the problem with make local for this spec.
This was resolved some time ago \o/