whatyouhide/xandra

Upgrading to DBConnection 2.0

Closed this issue ยท 6 comments

Hey @lexmag and @whatyouhide.
Currently, Xandra is using db_connection "~> 1.0", what causes conflict with the latest version ecto_sql and Phoenix 1.4 accordingly.
DBConnection contains many breaking changes and I'm trying to update the Xander: Nitrino@e16b2d7

Difficulties arise with the implementation of cluster support, and I feel that this requires a dive deeper into the code. Perhaps with this, I will need your help.
Therefore, I would like to know your opinion about the upgrade and maybe you already have some developments, and I'm doing useless work.

We don't have anything in the works for this. I really appreciate it though, and I think we should try to move to DBConnection 2.0 if possible, yeah. However, I won't have time to invest on this for now and @lexmag doesn't seem to either, so if you want to take a shot at this, you would be on your own for the time being.

+1, we are using xandra and now we can't upgrade to phoenix 1.4 one of our projects.
Seems like DBConnection.Pool behaviour is removed from db_connection ~2.0 and now Xandra.Cluster should be rewritten.

I managed it to pass tests in my commit:
spscream@2433f8d
I'm not sure if this is correct way to make it, meanwhile it works for me.

Made a pull request: #133

Great work @spscream! Will the PR be merged soon?

Not in the very near future unless time frees up for me. It will likely be a while, sorry.