whisklabs/docker-it-scala

DockerReadyChecker.and not implemented correctly

burgerdev opened this issue · 2 comments

Hello folks,

there is an issue with the implementation of DockerReadyChecker.and: it needs the implicit parameter ExecutionContext, but the default from DockerKit uses this.dockerContainers.length, which in turn needs all the containers (including ready checkers) to be configured. This results in a StackOverflowError.

Proposed solution: Implement DockerReadyChecker.and in terms of a combining class, something like

case class And(left: DockerReadyChecker, right: DockerReadyChecker) extends DockerReadyChecker { ... }

Cheers, Markus

P.S.: The same goes for or, naturally.

Thanks.That's a very good suggestion. #92 addresses it. Will release under 0.9.6

Nice, thanks!