whitecube/laravel-cookie-consent

Incorrect Time Calculation in Cookie Notification

Closed this issue · 1 comments

alien-rat commented

I hope this message finds you well. I am writing to report an issue I have encountered with the time calculation in the cookie notification feature.

When setting the time duration using the following code: ->duration(365 * 24 * 60)
the expected result should be exactly 1 year. However, the notification displays the time as "1 year, 1 month, 1 day," which is incorrect.

Expected Result:
The notification should display the time as "1 year."

Actual Result:
The notification displays the time as "1 year, 1 month, 1 day."

This discrepancy may confuse users and affects the accuracy of the information provided.

toonvandenbos commented

Hi @alien-rat, this is actually an issue with Carbon's intervals. We added a paragraph in our README regarding this issue.