Ctrl-s no longer searches in jupyter notebooks
notuntoward opened this issue · 4 comments
If I'm in a python file being viewed as a Jupyter notebook, search no longer works -- if I type Ctrl-s, nothing happens.
This was working as recently as last week. Not sure what changed.
Still an issue couple months later on a fresh VS Code install. Only have Jupyter and this extension installed.
VS Code: 1.77.1
Jupyter extension: v2023.3.1000892223 (tried v2022.6.1101950301, no luck)
Awesome Emacs Keymap: v0.47.0 (tried v0.42.0, no luck)
I haven't tried older VS Code versions.
Workaround: remapped VS Code's 'Find' to 'Ctrl + s'. Not ideal, but unblocks me.
I suspect that its the when clause for the two extensions key bindings.
Same here. Any simple workaround?
According to this you can use jupyter.isinteractiveornativeactive for filtering on jupyter notebooks. It has no upvotes, and since I uninstall jupyter I can't test it. Buf, if that link is correct you should be able to add
and !jupyter.isinteractiveornativeactive
to the existing when clause for emacs ctrl+s keybinding. Other hacks mentioned checking for the jupyter sidebar but they only work if the sidebar is open.
I am pretty sure it will work based on this ms article on jupyter when clauses. You may need to use more than one of these since there are different types of notebooks apparently. Just chain together negations with and to the ctrl+s keybinding of emacs.
if that works you can pull and change the package.json to contain the when clause that works for you and make a PR. maybe the author accepts it or you make your own version and load the visx,. I do this with several extensions where the author doesn't respond to my needs. That's why we code, no?