Should media functionality be included as a part of react-blocks?

Question

Should media functionality be included as a part of react-blocks?

Opened this issue 9 years ago · 4 comments

The current version of react-blocks includes handling media queries. The question is, whether it should be at the core of the library? Also there are a couple of notable libraries out there that handle media queries specifically. Again CSS media queries could be another use case. If the feature helps you, please lemme know.

Answer 1 · 2015-12-01T22:51:52.000Z

I vote for remove media query stuff from this lib. 👍

Answer 2 · 2015-12-01T23:13:53.000Z

@nishp1 Any specific reason? Why not to include media queries as a part of the lib?

Answer 3 · 2015-12-02T04:07:39.000Z

For the same reasons mentioned in #6. Mainly just to simplify this library. I have used react-responsive in the past and I think that combined with this will work great together.

Answer 4 · 2015-12-02T04:42:23.000Z

But don't you think for every block a separate <MediaQuery /> block has to be created which increases the boilerplate code? I mean, imho react-responsive also uses javascript to handle media queries under the hood.