makefile bug: $(DESTDIR) used twice in install.

Question

makefile bug: $(DESTDIR) used twice in install.

Closed this issue 9 years ago · 4 comments

From src/Makefile:

PREFIX = $(DESTDIR)/usr
LOCDIR = $(PREFIX)/local/bin

install -m 755 $(TARGET) $(DESTDIR)$(LOCDIR) evals to this on my system:
install -m 755 pixiewps /var/tmp/portage/net-wireless/pixiewps-1.2.2/image//var/tmp/portage/net-wireless/pixiewps-1.2.2/image//usr/local/bin

As you can see from the above, $(DESTDIR) is used twice.

Answer 1 · 2016-01-07T11:57:55.000Z

On every platform I tested $(DESTDIR) is equal to "" so I didn't notice. I don't think I will push another tag unless more issues pops out. Let me know if everything's good now.

Thank you.

Answer 2 · 2016-01-14T03:32:45.000Z

Looks good so far. Just need to test when I get some free time. Only other issue is I need to test if "make LOCDIR= install" so my ebuild can set the install of the bin to /usr/bin. If it fails, I'll open another issue with a suggested fix.

Answer 3 · 2016-01-14T11:32:49.000Z

Ok. I'll close this issue for now.

Answer 4 · 2016-05-25T15:24:25.000Z

@Techwolf FYI, we are maintaining that ebuild in Pentoo Linux. You are welcome to use it too
pentoo/pentoo-overlay@835ebec