wikimedia/grunt-stylelint

Add a fix config by wrapping grunt-stylefmt

jdforrester opened this issue · 7 comments

Add a fix config by wrapping grunt-stylefmt
radum commented

What do you mean by fix config? Like a predefined one to run? Embedded in this module?

If so you want to move stylelint to peerdeps? Or...?

Sorry, this was mostly a note to myself. :-)

Some coding standards/style linters, like jscs and phpcs, will automatically fix issues they find if passed fix: true; this is very helpful, especially for adding new rules to large code bases. This is provided in stylelint via stylefmt but we don't yet expose it.

This is provided in stylelint via stylefmt

This isn't true. stylefmt and stylelint are separate tools, although stylefmt can consume configs written for stylelint. There is already a grunt plugin for stylefmt: grunt-stylefmt. So that's already available to the community, and anyone wanting to format their CSS can use it in their grunt pipeline :)

radum commented

@jdforrester stylefmt is a separate tool and there is already a grunt plugin for it (grunt-stylefmt). Not sure if this will make sense to add here.

:) Just saw @jeddy3 comment about the same thing. I totally agree. This shouldn't be mixed up with stylefmt IMHO.

Sorry, I was paraphrasing http://stylelint.io/

Not adding it here will be immensely irritating; we'll just sub-duct it.

ntwb commented

FYI: The next release of stylelint will include experimental autofixing

edg2s commented

We pass through all config options, so setting 'fix' to true works as expected now.