will-stone/plastic

Research and try out new highlight backgrounds and borders

Closed this issue · 10 comments

With Code 1.21 we have new highlight border options: https://code.visualstudio.com/updates/v1_21#_new-theme-colors-and-removal-of-old-colors

In Plastic v1.7.0, I added a cornflower blue border to word highlight. I'd like to improve the highlighting further. e.g. do we need background colours on words highlighted with a border, or maybe a different background colour?

I can refine this over time.

This seems good so far:

"editor.wordHighlightBackground": "#00000000",
"editor.wordHighlightStrongBackground": "#00000000",
"editor.wordHighlightStrongBorder": "#D2D6db",

Word highlight? What am I missing? I tried double-clicking a word. I tried selecting multiple words with Apple-D. I tried searching for a word.

Click a variable to see the borders.

I've never seen this before as the feature does not appear to work in Go or Python, and I don't use Javascript on a regular basis. I'll have to go figure out why as I really like it.

Instead of pure black, why not use your theme color Woodsmoke #181A1F which is darker than the background of the editor window, but still within the theme palette?

Sorry, what is currently pure black?

Sorry, I should have been more clear. You had pasted this above:

"editor.wordHighlightBackground": "#00000000",
"editor.wordHighlightStrongBackground": "#00000000",
"editor.wordHighlightStrongBorder": "#D2D6db",

That's fully transparent, not black.

Hmm ... let me show you what I see instead.

Here is what I see on my screen when I add the first of those 3 lines:
screen shot 2018-03-10 at 10 38 24 am

And here is what I see when I comment the line out:
screen shot 2018-03-10 at 10 38 47 am

Weird, now I can't reproduce what I displayed above. I restarted my VSCode, so maybe it was in a funky state.