willmartian/div.js

can't create divs

Closed this issue · 6 comments

jcesarmobile commented

Added

<div is="div">
      <div is="p">hello</div>
</div>

and my page hangs

please, fix ASAP

Pika-Pool commented

Lol nice catch. Its a simple fix. Just use the selector div[is]:not([is="div"]). Or just remove the is attribute when adding attributes in swapDivs

@willmartindev , I would love to add a pull request if you could tell me which method u like better😄😄

Vinnl commented

Any updates on this? It's been two hours and still no fix, making this library literally unusable. I'm going back to canvas.js.

  • 😄6
willmartian commented

@jcesarmobile Thank you for the issue and the code reproduction.

@Vinnl Sorry!!! This project's popularly has gone to the moon and I have been trying to keep up with all of the open issues

@Pika-Pool a PR removing the is attribute after swapping would be very helpful! Feel free to PR! Yay #opensource 🌈

Vinnl commented

(@willmartindev To emphasise because I'm starting to feel guilty, I was parodying entitled comments on GitHub issues, I'm not actually angry :P )

  • ❤️1
willmartian commented

(@willmartindev To emphasise because I'm starting to feel guilty, I was parodying entitled comments on GitHub issues, I'm not actually angry :P )

Oh yeah I got you and I thought it was funny! Carry on mate :)

willmartian commented

Closing a la #2, great work everyone!

  • 🎉3