Change signature for `containsAll()`

Question

Change signature for `containsAll()`

evant opened this issue 8 years ago · 5 comments

right now it's containsAll(vararg Any?) which it makes it too easy to accidentally pass in listOf(foo) instead of *listOf(foo)

Answer 1 · 2017-05-05T00:26:48.000Z

Just curious about this... we could just have it throw an error (as it currently does). I could add another test to ensure that this behavior is kept and consistent.

Also, iirc - for now Kotlin only supports the spread operator for arrays *arrayOf(foo) and not collections like lists *listOf(foo)

Answer 2 · 2017-05-05T13:52:45.000Z

Hm good point, maybe a separate collection overload?

Answer 3 · 2017-05-27T17:14:05.000Z

Looks like this is impossible without https://youtrack.jetbrains.com/issue/KT-13198

Answer 4 · 2017-06-02T18:17:45.000Z

Looks like a blocker. Can't think of a way around this 😕

Answer 5 · 2018-05-06T11:18:51.000Z

containsAll(*listOf(...)) doesn't event work for me. Need to put .toTypedArray() on the end too. Deal-breaker. :(