wilson-eft/wilson

Upload of wilson v2.3 to PyPI

peterstangl opened this issue · 10 comments

peterstangl commented

@jasonaebischerGIT @dvandyk @klieret @DavidMStraub I just released wilson v2.3 but the upload to PyPI didn't work and I realized that only you are PyPI maintainers of wilson. It would be nice if one of you could upload the latest release to PyPI.

DavidMStraub commented

Hi, why did the workflow fail?

peterstangl commented

I thought it didn't work since I'm not a maintainer on PyPI, but actually it seems that the workflow was not triggered at all by the new release and I don't know why.

DavidMStraub commented

Looking into it. It did run but this IF
https://github.com/wilson-eft/wilson/blob/master/.github/workflows/check%2Bdeploy.yaml#L72
evaluated to false. Offending line added by @dvandyk in 3660307.

DavidMStraub commented

Uploaded to PyPI, but the workflow should be fixed.

  • 👍1
peterstangl commented

Looking into it. It did run but this IF https://github.com/wilson-eft/wilson/blob/master/.github/workflows/check%2Bdeploy.yaml#L72 evaluated to false. Offending line added by @dvandyk in 3660307.

Where do you see this? I don't see any workflow run for the release at all. The last workflow run I see is from the commit that changed the version number and there this IF in https://github.com/wilson-eft/wilson/blob/master/.github/workflows/check%2Bdeploy.yaml#L72 evaluates to false since it was a commit and not a release that has triggered the event. Were you looking at that one?

  • 👍1
dvandyk commented

Looking into it. It did run but this IF https://github.com/wilson-eft/wilson/blob/master/.github/workflows/check%2Bdeploy.yaml#L72 evaluated to false. Offending line added by @dvandyk in 3660307.

Hi @DavidMStraub, this line is correct, since it prohibits deployment on all events except a release event.
@peterstangl is right, there should be another workflow appear in the list, triggered by a release event. Looking into it.

  • 👍1
dvandyk commented

And here we go... I used the wrong event type:

Note: Workflows are not triggered for the created, edited, or deleted activity types
for draft releases. When you create your release through the GitHub browser UI,
your release may automatically be saved as a draft.

Here

wilson/.github/workflows/check+deploy.yaml

Line 8 in bf8cf0d

types: [created]

it should read [published].

peterstangl commented

@dvandyk indeed, I first drafted the release before publishing it. So I actually never "created" it and thus the workflow was not triggered.

dvandyk commented

PR #99 should fix this issue, and another that I noticed while reading the Github Actions documentation.

  • 👍1
peterstangl commented

Fixed by @DavidMStraub uploading the release and @dvandyk fixing the workflow in #99.

  • 👍1