wingspan/wingspan-forms

fresh clones have broken build because bower sucks

Closed this issue · 4 comments

I just ran into bower/bower#1403 bower/bower#1404

which, as of July 11, means bower depends on a module via a semver, and the semver is not correct, and the module released an update that broke bower, so fresh 'npm install's get the bad dependency and the bower:install step fails with "Arguments to path.join must be strings".

The workaround is to add these to the bottom of package.json, then clone fresh and run npm install again

"tmp": "0.0.23",
"bower": "1.3.6"

Not sending a pull request, as this might not even impact you guys and will probably go away shortly.

We can fix this by upgrading the grunt-bower-task dependency to 0.4.0.

I confirm that changing the dependancy version of grunt-bower-task dependency to 0.4.0 fixed the problem.
Shall we open a PR ?

Should this project even be using bower? Since wingspan-forms is a library, I think it would be up to the application using wingspan-forms to decide how to resolve dependencies, whether via bower or something else. Maybe we can just remove bower completely, or use it only for the samples?

Upgraded grunt to 0.4.5 and bower to 0.4.0.