winjs/winstrap

jQuery 2.2.0 and smooth scrolling selector

Closed this issue · 6 comments

jquery/jquery@86e62d8

the above commit broke the selector in app.js on this line. Adding the quotes seems to take care of the issue.

$('[data-scroll="smooth"] a[href*=#]:not([href=#])').on('click', function () {

Could you show your revised code, I've got the same issue, and had to roll back jquery version.

change the above line to this

$("[data-scroll='smooth'] a[href*='#']:not([href='#'])").on('click', function() {

@jasonaken Oh yeah. Now it doesnt throw error with jQuery v2.2.0

Thanks

@jasonaken, thanks for the fix! This change will be included in the next release.

very nice

Fixed, #137.