withastro/astro.build

Flashing issues

Closed this issue · 4 comments

jamesli2021 commented

I could notice the banner Astro version 2.1 just shipped! at the top of the page could "flash and disappear" despite the top banner has been closed, not obvious with a fast machine:
https://astro.build/showcase/
https://astro.build/blog/
https://astro.build/about/

Tested on macOS Ventura, Macbook M1 and latest Firefox.

tony-sull commented

This should have been handled by a <script> in the head, I'll take a look!

At first glance it's actually using <script is:inline> which may very well be the issue, pretty sure that'd put the script inlined in the <body> after the notification banner renders

jamesli2021 commented

Found any fix?

tony-sull commented

Closed this last week because we weren't using the notification banner anymore

Well, turns out the banner is making a comeback! There's a fix for this in #787 where the banner is added back in, re-opening this issue to make sure the fix is tracked properly