withastro/roadmap

<Code> doesn't support passing a meta string to Shiki

jcayzac opened this issue · 2 comments

jcayzac commented

Astro Info

Astro                    v4.12.2
Node                     v20.15.1
System                   macOS (arm64)
Package Manager          unknown
Output                   static
Adapter                  none
Integrations             astro-icon
                         @astrojs/preact
                         @astrojs/mdx
                         @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

<Code> doesn't support passing a meta string to Shiki's highlighter, breaking the functionality of multiple shiki transformers.

What's the expected result?

<Code> should support passing a meta string to Shiki's highlighter and not break the functionality of multiple shiki transformers.

Link to Minimal Reproducible Example

https://astro.build/

Participation

  • I am willing to submit a pull request for this issue.
jcayzac commented

I'll send a PR.

Princesseuh commented

Thank you for the PR, I'll just move this issue to a roadmap discussion, since it's more of a feature request (and it'll be closed anyway in the next minor, thanks to your PR)