Please don't break shell comments!
brandondrew opened this issue · 1 comments
brandondrew commented
Checks
- I have searched github.com/withfig/fig/issues and there are no duplicates of my issue
- I have run
fig doctor
in the affected terminal session - I have run
fig restart
and replicated the issue again
Operating system
macOS 12.6.6 (21G646)
Expected behaviour
This may be some new "feature" of Fig that was added while I had it disabled (which I did because of the bloat that Fig adds when you have lots of shells open) but I'm pretty sure I never agreed to let Fig co-opt my comments and run unexpected code on my machine.
#
can be very useful in the shell to comment out a command (and therefore not run it!) when you realize you have to run something else first.
Please don't break this.
Actual behaviour
Fig began running code in my terminal, without my permission, without explanation.
Steps to reproduce
Type # some_command
Environment
fig-details:
- 2.17.1
hardware-info:
- model:
- model-id:
- chip-id: Apple M1
- cores: 8
- mem: 16.00 GB
os-info:
- macOS 12.6.6 (21G646)
environment:
- shell: /bin/zsh
- terminal: kitty
- cwd: /Users/brandon/Code/Rails/portal
- exe-path: /opt/homebrew/bin/fig
- install-method: brew
- env-vars:
- FIGTERM_SESSION_ID: af20a317-454d-42a1-9426-2383f8964d1e
- FIG_PID: 5919
- FIG_SET_PARENT: af20a317-454d-42a1-9426-2383f8964d1e
- FIG_SET_PARENT_CHECK: 1
- FIG_TERM: 2.17.1
- FIG_TERM_TMUX: 2.17.1
- PATH: /Users/brandon/.pyenv/shims:/Users/brandon/.nvm/versions/node/v14.21.1/bin:/Users/brandon/.rbenv/shims:/Users/brandon/.config/zplug/repos/zplug/zplug/bin:/Users/brandon/.config/zplug/bin:/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin:/Users/brandon/bin:/Users/brandon/.rbenv/versions/3.3.0/bin:/opt/homebrew/Cellar/rbenv/1.2.0/libexec:/Users/brandon/.pyenv/shims:/Users/brandon/.nvm/versions/node/v14.21.1/bin:/Users/brandon/.rbenv/shims:/Applications/kitty.app/Contents/MacOS:/Users/brandon/.fig/bin:/Users/brandon/.local/bin:/Applications/ShellHistory.app/Contents/Helpers:/Users/brandon/Source/Roc/latest:/Users/brandon/.cargo/bin:/Users/brandon/bin/:/Users/brandon/.asdf/installs/postgres/9.6.22/bin/:/Applications/ShellHistory.app/Contents/Helpers:/Users/brandon/Source/Roc/latest:/Users/brandon/.cargo/bin
- SHELL: /bin/zsh
- TERM: screen-256color
- ZDOTDIR: /Users/brandon/.config/zsh
- __CFBundleIdentifier: net.kovidgoyal.kitty
mschrage commented