cursor loses position when typing any block level styles

Question

cursor loses position when typing any block level styles

watlandc opened this issue 8 years ago · 14 comments

Issue

When typing block level styles (ordered lists, headings, block quote, code block) the cursor immediately jumps to the line above the current position making block level styles unusable.

I'm experiencing the issue when using spectrum.chat, but the issue does not appear in the draft-js-markdown-plugin demo.

Browser and library version

Experienced the issue using an up-to-date version Chrome browser:

Version 65.0.3325.181 (Official Build) (64-bit)

It appears Spectrum uses version "draft-js-markdown-plugin": "1.3.0",

Demo

Video demo from spectrum.chat:

https://www.dropbox.com/s/ladtyfzru2qtz86/bullet%20point%20issue.mov?dl=0

Answer 1 · 2018-04-04T05:05:34.000Z

Upon further testing, the cursor loses position when typing headings too.

Answer 2 · 2018-04-04T20:17:02.000Z

wooot - @mxstbr is the latest version installed?

I can repro this on spectrum.chat in chrome btw, but not when I test the draft-js-markdown plugin in isolation

Answer 3 · 2018-04-04T20:35:45.000Z

I updated the issue as requested, noting that Spectrum.chat is currently using:

"draft-js-markdown-plugin": "1.3.0"

Answer 4 · 2018-04-04T21:10:16.000Z

oh that's unfortunate

Answer 5 · 2018-04-04T21:49:33.000Z

Hmm might be one of our other plugins interfering?

Answer 6 · 2018-04-05T05:02:38.000Z

@mxstbr this can be reproduced in a dev env I suppose?

Answer 7 · 2018-04-07T03:57:34.000Z

I've started looking into this as well myself. This exists in my own project, but I haven't been able to reproduce it in the demo (yet). I won't be able to take a further look until Monday.

Answer 8 · 2018-04-08T09:52:31.000Z

We upgraded to v1.4.0 and it's definitely still happening, ref withspectrum/spectrum#2779. We haven't updated anything else, so it must be some kind of mismatch?

Answer 9 · 2018-04-08T15:46:15.000Z

This doesn't seem to be a plugin issue? I went in locally, removed all plugins except for the markdown plugin and it still happens for some reason. Trying to pinpoint the issue now!

Answer 10 · 2018-04-08T15:59:31.000Z

This issue does not exist on Spectrum with v1.1.0 of the markdown plugin, but it does exist with v1.2.0 of the markdown plugin.

Here's the diff: 460a2d8...65e6779 Some change in there causes this broken behavior, but I'm not sure what it could be. @juliankrispel any clues?

Answer 11 · 2018-04-08T18:11:46.000Z

Typically something like that is an issue with a “bad” SelectionState. I’ve been ill this weekend but ai’d be keen to try repro it early next week

…

On Sun, Apr 8, 2018 at 5:59 PM Max Stoiber ***@***.***> wrote: This issue does not exist on Spectrum with v1.1.0 of the markdown plugin, but it does exist with v1.2.0 of the markdown plugin—no other changes. @juliankrispel <https://github.com/juliankrispel> any clues what part of the code changes could be causing this behavior? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIhWrcYHmdbDqFsW0M1SErppRkItVBEks5tmjPjgaJpZM4TGLBC> .

Answer 12 · 2018-04-09T09:27:42.000Z

Hmm, something seems to be generally broken—I'm also not seeing the new languages switcher, and exiting code blocks with ``` doesn't work either 😕

Answer 13 · 2018-04-09T17:23:41.000Z

ok - I managed to repro it - by installing react-dom@16.2.0 😆 yep - banged my head against the wall for a few hours :/ - now I can actually debug the problem @mxstbr regarding the language switcher - I can totes see that in there when building alpha

Answer 14 · 2018-04-09T17:37:34.000Z

Ok - I found the issue - the issue was as I suspected - corrupt SelectionState. It had always been there, but for some reason one of my updates must have exposed the bug - so here's the pr to fix it -> #47