wix-incubator/react-native-zss-rich-text-editor

Running slowly on Android

ColdStar007 opened this issue · 20 comments

ColdStar007 commented

It works fine on iOS, but it runs very slowly on Android.

minhphung210 commented

same issue

antony-meunier commented

Same here !

arneson commented

@ColdStar007 @minhphung210 @antony-meunier
There is an infinite loop running in the android version, it has been resolved in a few different forks but there is little to no activity in this repo unfortunately.

You can depend on the tag 1.1.1 in my fork of this repo which has a fix.

https://github.com/arneson/react-native-zss-rich-text-editor.git#1.1.1

  • 👍2
minhphung210 commented

@arneson arn
your solution not work for me :(
thank for reply

arneson commented

That's unfortunate. Have you made sure to do a clean native build before testing? As the problem is in the editor.html file in the library which is only copied over on build, not reload.

export-mike commented

@arneson keen to make a hard fork? I'm having issues. lets collaborate I have a fork too: https://github.com/export-mike/react-native-zss-rich-text-editor

I'm keen to change this to use the recommended react-native-web-view which is faster for ios and also has window.postMessage working without hacks.

  • 👍1
arneson commented

@export-mike

Yeah, I'd love to get this library working properly again. Would love to collaborate.

It's the commit with message fix getCaretPosition.

arneson@7704a0e#diff-5764eca5893a91bd5fb61afbae89595d

Worth noting is that I did not write that commit but pulled it from charpeni 's fork.

  • 👍2
export-mike commented

ok cool sounds great.

basically the fork of the editor I'm using has the ability to render custom buttons. I need to change it to use the react-native-web-view

I can pull in this infinite loop fix manually. what other changes have you introduced?

what functionality are you working to support/fix?

arneson commented
  • 👍2
export-mike commented

Yeah great. basically the work I have done so far allows custom components to be rendered.

  • Need to successfully remove the title editor from the editor if not required.
  • Show and hide toolbar successfully on android
  • Android Performance
  • iOS shows a black line page-break kinda thing when scrolling.
  • 👍1
export-mike commented

Bottom 2 points need to be completed.

arneson commented

@export-mike
Don't think I've seen the last one.
Could you send over a screen shot?

arneson commented

Saw that link way too late. It’s dead now :) @export-mike

ethanyuwang commented

@arneson Thanks your fork worked for me!

ashokkumar88 commented

@arneson your version supports hashtag and mentions?

arneson commented

@ashokkumar88
I have not added that functionality, so if it exists in original package then yes, otherwise no.

export-mike commented

looks like UIWebView has been deprecated. I'll be updating https://github.com/export-mike/react-native-zss-rich-text-editor to use WKWebView.