wix/react-native-navigation

3D touch stops working after "Peeking" a view without popping it

charliesbot opened this issue · 13 comments

charliesbot commented

Issue Description

If a view is "Peeked", without popping it, and then you actually try to pop a view, it will trigger the transition animation, but it won't change to the new view.

At this point, if you press normally to any view that can trigger a navigation, that won't occur anymore.

Steps to Reproduce

  1. Peek a view
  2. Don't pop it
  3. Peek a view again, and then press harder to pop it
  4. The transition won't happen
  5. Press that view to navigate
  6. Again, the transition won't happen anymore

demo

demo2

Environment

  • React Native Navigation version: v1.1.322
  • React Native version: 0.51
  • Platform: iOS
  • Device info: Simulator/Debug mode
guyca commented

ping @birkir :)

  • 👍1
habovh commented

I have the same issue. It's kind of funny even the onPress event fails though 🤔
I first thought the issue happened because I was calling the same push() function in both onPress and onPressIn, including preview* parameters, but I tried calling with completely separate parameters and the issue persists.

birkir commented

Thanks for the bug report!

This may be a iOS quirk (or not), but when logging out which controller we are previewing, xcode shows the correct one, when committing it also logs the correct one but commits the wrong one. Pretty weird.

I'm investigating this! Funny thing is, sometimes when testing other methods of pushing the preview (like using onLongPress or similar) it works 99% of the time.

So maybe its a timing issue but something has to be fixed on the ObjC side of things.

  • 👍2
  • ❤️3
anonrig commented

Do you have any priority and an ETA on this issue @birkir ?

  • 👍3
karlsander commented

I'm also struggling with this issue. Is there a fix forthcoming? And in the meantime, has anyone found a decent workaround?

birkir commented

I am busy with other things at the moment.

Use onLongPress in stead of onPressIn that works!

  • 👎1
karlsander commented

It works, but it doesn't provide a proper Peek & Pop experience. It would be a shame if this never gets fixed, as the Peek and Pop support in react-native-navigation is otherwise great. I understand that theres a lot on your plate and maybe I should just investigate the issue myself. Is fixing this on the map for v2 at least?

birkir commented

Why doesn't it provide a proper Peek & Pop experience? Too slow?

I always seem to get to a dead end when looking into this issue. AFAIK this hasn't been implemented in V2, and I have a feeling that this won't be an issue in V2.

There is something fundamentally wrong with the navigation controller in V1.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

habovh commented

I believe this issue does not deserve being marked as stale... What do you guys think? Any idea on how to fix this, or do you plan on leaving it as-is in favor of V2?

guyca commented

Since @birkir implemented this in v2 as well 🙇 and we're not supporting v1 anymore I'm opting to close. @habovh You can easily migrate to v2 using this library.

habovh commented

@guyca that's good news! Thanks for the tip, looking forward to updating to v2!

birkir commented

V2 does not have any issues like V1 has, I think the fundamental changes in how the VC's are managed in V1 vs V2 was the root cause.

  • 🎉1