wkcaj/safecurl

When testing against whitelisted ip's, it only checks whether there is a valid whitelisted ip, and not whether there is an ip that doesn't match

hughdavenport opened this issue · 1 comments

from https://github.com/fin1te/safecurl/blob/master/src/fin1te/SafeCurl/Url.php#L138

from my take on this, you can go have say whitelist of ('1.2.3.4'), and a host that resolves to ('4.3.2.1', '1.2.3.4'), and this check will set valid to true after checking the second ip, but the first is the one most likely to get used, and is not whitelisted.

I could be wrong, but my thinking is that all the ips should match something on the whitelist?

Cheers,

Hugh

dupe of #10