wldcordeiro/perdido

Upgrade dependencies

Closed this issue · 11 comments

wldcordeiro commented

Babel specifically needs to be updated.

rosskevin commented

@wldcordeiro - I'm picking this up.

I'm running into a ton of old eslint issues, would you mind if during this process I switched eslint over to https://github.com/feross/standard?

wldcordeiro commented

I'm not a fan of Standard (Semicolon fan, even if you can go without. I find them to be nice for readability), however I would be down with AirBnB's eslint config. https://github.com/airbnb/javascript

rosskevin commented

Airbnb + these old rules get us close:

  "rules": {
    "semi": [
      2,
      "always"
    ],
    "brace-style": [
      2,
      "1tbs",
      {
        "allowSingleLine": true
      }
    ]
  }
wldcordeiro commented

I dig it! I haven't ever fully formalized my preference in JS code but that's just about it. 👍

rosskevin commented

did npm test work previously?

wldcordeiro commented

Yes, it would open a browser tab and have the test suite results shown.

rosskevin commented

So the browser env cannot find require. I'm more familiar with a karma + mocha setup.

Any reason not to add karma and do the easy switch to the more common mocha?

wldcordeiro commented

I think I had lifted the test suite from JSS or one of its plugins originally and hadn't bothered to change yet, I do generally prefer karma + mocha as I can run that headless.

rosskevin commented

I'm not familiar with webpack/karma/mocha setup, I'm used to karma+mocha on libraries.

With that said, I've got the project setup just like jss, though I have one blocking issue:

ERROR in ./tests/index.js
Module not found: Error: Cannot resolve module 'perdido' in /Users/kross/projects/perdido/tests
 @ ./tests/index.js 31:15-33

I'm not sure how modules are resolved in this specific config, but it appears to me that webpack is compiling all files and they are available, quite the same as jss (which succeeds for me).

Can you take a quick look? Do you want me to submit the PR with the understanding that this work is complete...except the test doesn't quite run yet?

https://github.com/rosskevin/perdido/tree/update-dependencies

rosskevin commented

I seemed to have it resolved with a local file import, not sure why it is different than jss.

rosskevin commented

PR available - does a bunch to get everything up to date, and you might try turning on travis as well.