wmde/WikibaseDataModel

ClaimList::getBestClaimPerProperty

Closed this issue · 2 comments

thiemowmde commented

Claims::getBestClaims pretty much does what it says. It returns the claims that happen to have the highest rank. It can be used in conjunction with Claims::getClaimsForProperty to get the best claim per property but this is optional.

I suggest to rename ClaimList::getBestClaims to ClaimList::getBestClaimPerProperty to make it clear what it does (which is a combination of the other two operations).

I'm also not happy with terms like "best" or "truth" but I honestly don't have a better idea, at least not at the moment. "getHighestRankedClaims" is not really better.

JeroenDeDauw commented

@thiemowmde can you submit a PR with this rename of ClaimList::getBestClaims? Else it will not happen...