Move patch code out of model classes
Closed this issue · 3 comments
Methods like Entity::patch should be moved into separate Patch classes in another namespace. Perhaps all code with patches and diffs can be even moved into another component but that's another discussion.
The badge part has already been started. I was pair programming this with @WMDE-Fisch. https://github.com/wmde/WikibaseDataModel/tree/entitypatcher
Since we are now working on actual Fundraiser code, I'll finish this up myself soon.
That's cool. \o/ Will you actually create new classes for them or even move the diff code into its own package? Also I see not much progress on the entitypatcher branch so I'm asking when you plan to finish this.
I will finish this today. The patching code will likely be similar to the diffing code: https://github.com/wmde/WikibaseDataModel/tree/master/src/Entity/Diff
Not planning on putting this in its own component. Why would you do that?