Clean up EntityDiff and ItemDiff

Question

Clean up EntityDiff and ItemDiff

Closed this issue 9 years ago · 5 comments

EntityDiff makes assumptions that all entities have aliases, labels, descriptions and claims. It is generally not well designed. claim is used as key for statements.

Creating a well designed alternative from ground up might be the way to go.

Answer 1 · 2014-09-26T22:09:27.000Z

We might also discuss if the diffing and patching code should stay in the DataModel or be moved into another package like it is already done for the serialization code.

Answer 2 · 2014-12-11T15:23:18.000Z

https://phabricator.wikimedia.org/T78298

Answer 3 · 2016-02-06T14:16:17.000Z

No longer in this component

Answer 4 · 2016-02-07T08:06:52.000Z

Well better create a new one for it then ;p wmde/WikibaseDataModelServices#108

Answer 5 · 2016-02-07T08:54:12.000Z

It is already tracked on phabricator so I assumed that would be enough.