wmde/WikibaseDataModel

correct namespace of tests

Closed this issue · 5 comments

JanZerebecki commented

Like in #250 just for the rest.

thiemowmde commented

I would like to do this but it seems there are at least three different naming schemes for the namespaces:

  • Wikibase\Test\<Module>
  • Wikibase\Test\DataModel\<Module>
  • Wikibase\DataModel\Test\<Module>
  • Wikibase\DataModel\<Module>\Test

Not counting the "all tests in one namespace" namespaces:

  • Wikibase\Test
  • Wikibase\DataModel\Test

Also it's not clear if the namespace should be Test or Tests? I see some Tests in Wikibase.git.

JeroenDeDauw commented

Different schemes are used in different packages. Good to have a consistent scheme within a package though.

Also it's not clear if the namespace should be Test or Tests? I see some Tests in Wikibase.git.

Personally I've stuck to Tests for some time now, at least for new components. I suspect this is the most common one we have across all components.

thiemowmde commented

The namespaces in this package's tests are all but consistent. Which one to choose? At the moment I prefer Wikibase\DataModel\Tests\<Module>.