wncc/WnCC

Year-Wise tab should have their own url

Opened this issue ยท 6 comments

If we click on a certain year's tab in events, the url remains the same http://wncc-iitb.org/events/
It would be better if the link is something like http://wncc-iitb.org/events/year?=2016 or something. I remember someone did it before.

Owl-A commented

Are you sure? I don't think this is correct in practice. ๐Ÿ˜•

Events are pretty less. Overkill lag raha hai ๐Ÿ‘€

I think @ydidwania had achieved this before. Can you find out what broke it and fix it? ๐Ÿ™‚

Right now we are loading everything(all events) and tabbing them

Owl-A commented

I agree with grub, @Nihal isn't that done for different pages ๐Ÿ˜•

Yeah, I agree it's not exactly the "right" way. But to do that with different pages, you need to have a backend that understands the GET request parameters. Since we are using Jekyll, if we want to do this, it'd have to be the Javascript way.

About whether or not we need it, we do have a good number of tabs. It might be a good idea to have a different link for each one of them to ease sharing. Kind of like how the part after the # in https://github.com/nihal111/WnCC/issues/108#issuecomment-3082435620 takes you to that element.