wofsauge/External-Item-Descriptions

Wrong craft display in the craft bag

JustJabka opened this issue · 7 comments

I have for some reason some of the crafts are displayed wrong: for example, I tried to craft "C Section", but I got "Options?" on the output. Even though I have "C Section" unlocked.

20240506202611_1
image

I don't have any mods that add new items. Here's a list of mods: https://steamcommunity.com/sharedfiles/filedetails/?id=3240990722

the "Bag" section displays the correct result for your craft, so the calculation seem to work in general.
The problem seem to be somewhere in the algorithm that calculates all possible recipes with the currently available pickups. Thats very hard to debug without knowing without the seed of the run, and the number of items you have unlocked so far on the savefile.

In general, if Repentogon is installed, bag of crafting should work, even with item mods installed.

Is the problem something that occurs frequently for you? if yes, can you maybe send your savefile so we can test out what fails here? and maybe send a seed as well, where we can test out the issue.

Thanks, do I need to send the save file from "Steam/userdata/250900" or from "user/documents/My Games/Binding of Isaac Repentance"?

the steam userdata one please

hey.
The save files worked well. thanks for providing them.
We made a few changes to the bag of crafting code, and it seems like i am no longer able to reproduce the issue with your save file. Therefore it seems to work for me with repentogon now.

Can you maybe check if the issue still persists?

Hi, I checked, the issue is gone, thank you very much

Awesome! Thanks for testing :)