Wrong language code
FTno opened this issue · 6 comments
Refer to pull request 67625cb
Just installed V2.3 and the translated strings from the pull request are not displayed (strings are in english).
After decompiling the apk file I see that there are both a values-no and a values-nb folder which contain translations from different sources, with values-no containing the referred pull request.
This puzzled me, but I now see that the language code of the pull request has been changed from 'nb' to 'no', and I'm pretty sure this is the problem so please change it back to 'nb'.
I see that one new string has been added recently to the norwegian language file: <string name="turned_on">En</string> (the english source: <string name="turned_on">On</string>)
This should be a correct translation: <string name="turned_on">På</string>
By the way, I have also made a pull request for the compassview: woheller69/CompassView#1
For Norwegian the code should be 'no' as far as I understand
Or should I use the strings for both, no and nb?
Most apps I have seen uses values-nb (or values-nb-rNO). values-no doesn't work on phones I have tried, but on the other hand it shouldn't harm to have both folders with duplicate content.
Then I will put the content in nb and no folders.
Will also do this for your compassview PR.
Sorry I did not receive a notification for this PR.
Please try. CompassView is also merged and strings are in values-nb and values-no
Uninstall
Remove .zip and install
The test version displays the norwegian strings fine (compassview too). Thanks!