wojtekmaj/react-datetimerange-picker

Typescript Support

Zunaib opened this issue · 9 comments

Zunaib commented

Hi, Is there any typescript support.
In case i want to extend your lib's props ?

wojtekmaj commented

Hi,
there's none, but there are works to migrate typings to our sibling libraries like React-Date-Picker and React-Date-Picker. Once that's done I believe it should be fairly easy to add support for this one.

Zunaib commented

Currently, I've maneuvered my own definitions, i'll keep an eye for the work to be done.

Zunaib commented

Can i contribute my index.d.ts file ?
Made it with propTypes and Default Props.

wojtekmaj commented

Sure! Typings should be contributed to DefinitelyTyped though, not this repository :)

Psvensso commented

Have a look and if you feel like it, approve, this PR.
DefinitelyTyped/DefinitelyTyped#48743

  • ❤️2
gamegee commented

Hi, I am trying to install the DefinitelyTyped package, but the name does not match the implementation package name. So typescript is not able to resolve the package.

types: @types/wojtekmaj__react-datetimerange-picker

implementation: @wojtekmaj/react-datetimerange-picker

Psvensso commented

@gamegee
This is correct naming based on convention. As pointed out in the readme

This should work out of the box, Typescript knows about this convention and how to resolve it if you have default tsconfig setup.

  • 👍1
gamegee commented

Thx @Psvensso I didn't know about it
I probably need to tweak a bit my tsconfig :)

wojtekmaj commented

Closing as DefinitelyTyped/DefinitelyTyped#48743 is merged and published.