wojtkowiak/meteor-desktop

1.0.0: splash screen is not sized properly

KoenLav opened this issue · 8 comments

Config:
"plugins": {
"meteor-desktop-splash-screen": {
"version": "0.3.0",
"windowSettings": {
"width": 800,
"height": 600
}
}
},

Expected: splash screen is 800 x 600.

Result: splash screen is very small (50 x 50?).

Other than that I haven't noticed any issues when upgrading to 1.0.0.

Maybe the autoUpdate functionality? It seems that, after installing, the app immediately pulled in a new client version (Meteor) but only applied it after restarting (not sure if this is to be expected?).

darqs commented

Please check firstly with meteor-desktop-splash-screen@0.4.0

Problem still present @0.4.0

Ohh weird that I did not spot this while testing. Electron 2.0 have a lot of issues reported on the window appearance when frame: false transparent: true is used.
I am not sure if I will be able to come up with a workaround until the issues are resolved in Electron.
Will let you know.

Try 0.4.2 now

The screen is now the proper size, however previously the image auto-scaled to 100% of whatever size you set, now it leaves the images as-is and centers it.

This is quite easily fixed by resizing the image, so I will just do that for now.

Do you have anything else than

{
"version": "0.3.0",
"windowSettings": {
"width": 800,
"height": 600
}

in plugin settings?
Can you attach the image or do some screenshots?
And I forgot to ask in the first place, on what platform that happens?

Try now with meteor-desktop 1.1.0 and splash screen 0.4.3 - there is a fix for the window problem in electron 2.0.2, not sure if this will help for your case, but it solves the issues with the default style

Sorry for the late reply.

Fixed using 1.1.0 and 0.4.3 with Electron 2.0.2!